Re: [PATCH -next 20/24] spi: sh-msiof: switch to use modern name

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Yang,

On Wed, Aug 16, 2023 at 11:43 AM Yang Yingliang
<yangyingliang@xxxxxxxxxx> wrote:
> Change legacy name master/slave to modern name host/target.
>
> No functional changed.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c
> @@ -79,7 +79,7 @@ struct sh_msiof_spi_priv {
>  #define SIRFDR 0x60    /* Receive FIFO Data Register */
>
>  /* SITMDR1 and SIRMDR1 */
> -#define SIMDR1_TRMD            BIT(31)         /* Transfer Mode (1 = Master mode) */
> +#define SIMDR1_TRMD            BIT(31)         /* Transfer Mode (1 = Host mode) */

Please do not change this register bit definition nor the comment, as
they match Rev 0.81 of the R-Car V4H Series Hardware User's Manual.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds