Re: [PATCH -next 15/24] spi: rspi: switch to use modern name

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Yang,

On Wed, Aug 16, 2023 at 11:43 AM Yang Yingliang
<yangyingliang@xxxxxxxxxx> wrote:
> Change legacy name master/slave to modern name host/target.
>
> No functional changed.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/spi/spi-rspi.c
> +++ b/drivers/spi/spi-rspi.c
> @@ -71,7 +71,7 @@
>  #define SPCR_SPE               0x40    /* Function Enable */
>  #define SPCR_SPTIE             0x20    /* Transmit Interrupt Enable */
>  #define SPCR_SPEIE             0x10    /* Error Interrupt Enable */
> -#define SPCR_MSTR              0x08    /* Master/Slave Mode Select */
> +#define SPCR_MSTR              0x08    /* Host/Target Mode Select */

Please do not change this register bit definition nor the comment, as
they match Rev 2.00 of the R-Car Series, 2nd Generation, and Rev. 1.30
of the RZ/G2L{,C} Group Hardware User's Manual.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds