Re: [PATCH -next 13/24] spi: rockchip: switch to use modern name

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Yang,

CC Heiko

On Wed, Aug 16, 2023 at 11:43 AM Yang Yingliang
<yangyingliang@xxxxxxxxxx> wrote:
> Change legacy name master/slave to modern name host/target or controller.
>
> No functional changed.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/spi/spi-rockchip.c
> +++ b/drivers/spi/spi-rockchip.c
> @@ -104,8 +104,8 @@
>  #define CR0_XFM_RO                                     0x2
>
>  #define CR0_OPM_OFFSET                         20
> -#define CR0_OPM_MASTER                         0x0
> -#define CR0_OPM_SLAVE                          0x1
> +#define CR0_OPM_HOST                           0x0
> +#define CR0_OPM_TARGET                         0x1
>
>  #define CR0_SOI_OFFSET                         23
>
> @@ -125,7 +125,7 @@
>  #define SR_TF_EMPTY                                    (1 << 2)
>  #define SR_RF_EMPTY                                    (1 << 3)
>  #define SR_RF_FULL                                     (1 << 4)
> -#define SR_SLAVE_TX_BUSY                               (1 << 5)
> +#define SR_TARGET_TX_BUSY                              (1 << 5)

I assume the register bit names come straight from the hardware
documentation, so you cannot just change them without making future
maintenance harder.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds