Re: [PATCH -next 04/24] spi: pic32: switch to use modern name

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Yang,

On Wed, Aug 16, 2023 at 11:43 AM Yang Yingliang
<yangyingliang@xxxxxxxxxx> wrote:
> Change legacy name master to modern name host or controller.
>
> No functional changed.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/spi/spi-pic32.c
> +++ b/drivers/spi/spi-pic32.c
> @@ -55,7 +55,7 @@ struct pic32_spi_regs {
>  #define  TX_FIFO_HALF_EMPTY    2 /* empty by half or more */
>  #define  TX_FIFO_NOT_FULL      3 /* atleast one empty */
>
> -#define CTRL_MSTEN     BIT(5) /* enable master mode */
> +#define CTRL_HSTEN     BIT(5) /* enable host mode */

I assume the register bit name (and the comment?) come straight from
the hardware documentation, so you cannot just change it without making
future maintenance harder.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds