Re: [PATCH v5 1/2] dt-bindings: spi: add loongson spi

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 31/03/2023 05:29, Yinbo Zhu wrote:
> Add the Loongson platform spi binding with DT schema format using
> json-schema.


> +properties:
> +  compatible:
> +    enum:
> +      - loongson,ls2k-spi
> +      - loongson,ls7a-spi
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/loongson,ls2k-clk.h>

Why do you need the header? Wasn't the entire point to remove it?

> +    spi0: spi@1fff0220{
> +        compatible = "loongson,ls2k-spi";
> +        reg = <0x1fff0220 0x10>;
> +        clocks = <&clk 17>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +    };


Best regards,
Krzysztof