On 3/28/23 07:21, Yang Li wrote: > According to commit 890cc39a8799 ("drivers: provide > devm_platform_get_and_ioremap_resource()"), convert > platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> > --- > drivers/spi/spi-rockchip-sfc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) If I were you I would make a single patch addressing all the drivers from SPI as this is a single logical change. You get extra points as you avoid polluting the log. > > diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c > index 4fabd2e0439f..6830ecaa270b 100644 > --- a/drivers/spi/spi-rockchip-sfc.c > +++ b/drivers/spi/spi-rockchip-sfc.c > @@ -576,8 +576,7 @@ static int rockchip_sfc_probe(struct platform_device *pdev) > sfc = spi_master_get_devdata(master); > sfc->dev = dev; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - sfc->regbase = devm_ioremap_resource(dev, res); > + sfc->regbase = devm_platform_get_and_ioremap_resource(pdev, 0, &res); No, you better use devm_platform_ioremap_resource() as res is not used afterwards. You'll get rid of the local variable too. > if (IS_ERR(sfc->regbase)) > return PTR_ERR(sfc->regbase); >