Re: [PATCH v2 2/2] spi: loongson: add bus driver for the loongson spi controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


在 2023/3/23 下午9:59, Mark Brown 写道:
On Thu, Mar 23, 2023 at 08:46:19PM +0800, zhuyinbo wrote:

I think add following change and that issue what you said will can be
fixed,   in addition, the spin_lock
was also not needed.   Do you think so?
@@ -101,8 +101,10 @@ static int loongson_spi_setup(struct spi_device *spi)
         if (spi->chip_select >= spi->master->num_chipselect)
                 return -EINVAL;

+       loongson_spi->hz = 0;
+       loongson_spi->mode &= SPI_NO_CS;
-       loongson_spi_update_state(loongson_spi, spi, NULL);
Looks plausible, yes - I'd need to see the full thing to verify.

okay, I will send v3.

[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux