Re: [PATCH v10 05/15] dt-bindings: soc: amd: amd,pensando-elbasr: Add AMD Pensando SoC System Controller
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v10 05/15] dt-bindings: soc: amd: amd,pensando-elbasr: Add AMD Pensando SoC System Controller
- From: Brad Larson <blarson@xxxxxxx>
- Date: Sat, 11 Mar 2023 15:32:26 -0800
- Cc: <adrian.hunter@xxxxxxxxx>, <alcooperx@xxxxxxxxx>, <andy.shevchenko@xxxxxxxxx>, <arnd@xxxxxxxx>, <blarson@xxxxxxx>, <brendan.higgins@xxxxxxxxx>, <briannorris@xxxxxxxxxxxx>, <brijeshkumar.singh@xxxxxxx>, <broonie@xxxxxxxxxx>, <catalin.marinas@xxxxxxx>, <davidgow@xxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <fancer.lancer@xxxxxxxxx>, <gerg@xxxxxxxxxxxxxx>, <gsomlo@xxxxxxxxx>, <krzk@xxxxxxxxxx>, <krzysztof.kozlowski+dt@xxxxxxxxxx>, <lee.jones@xxxxxxxxxx>, <lee@xxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-mmc@xxxxxxxxxxxxxxx>, <linux-spi@xxxxxxxxxxxxxxx>, <p.yadav@xxxxxx>, <p.zabel@xxxxxxxxxxxxxx>, <piotrs@xxxxxxxxxxx>, <rdunlap@xxxxxxxxxxxxx>, <robh+dt@xxxxxxxxxx>, <samuel@xxxxxxxxxxxx>, <skhan@xxxxxxxxxxxxxxxxxxx>, <suravee.suthikulpanit@xxxxxxx>, <thomas.lendacky@xxxxxxx>, <tonyhuang.sunplus@xxxxxxxxx>, <ulf.hansson@xxxxxxxxxx>, <vaishnav.a@xxxxxx>, <will@xxxxxxxxxx>, <yamada.masahiro@xxxxxxxxxxxxx>
- In-reply-to: <2691debf-0596-c265-468f-bb66d19f6db0@linaro.org>
- References: <2691debf-0596-c265-468f-bb66d19f6db0@linaro.org>
On 06/09/2023 09:46, Krzysztof Kozlowski wrote:
> On 07/03/2023 03:18, Brad Larson wrote:
>> On 06/03/2023 09:35, Krzysztof Kozlowski wrote:
>>>> On 06/03/2023 05:07, Brad Larson wrote:
>>>>> Support the AMD Pensando SoC Controller which is a SPI connected device
>>>>> providing a miscellaneous set of essential board control/status registers.
>>>>> This device is present in all Pensando SoC based designs.
>>>>>
...
>>>>> .../bindings/soc/amd/amd,pensando-ctrl.yaml | 60 +++++++++++++++++++
>>>>> 1 file changed, 60 insertions(+)
>>>>> create mode 100644 Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml b/Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..36694077b2e6
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml
>>>>
>>>> Your subject suggests this is pensando-elbasr but you write everywhere
>>>> pensando-ctrl. Confusing. Pick one.
>>>
>>> Actually pensando-ctrl is for sure not correct, because it misses the
>>> name of the SoC (you call it everywhere "elba").
>>
>> The reason I dropped elba as part of the name is this driver and its associated
>> SPI attached device (cpld or fpga depending on the board design) will be used
>> across a series of SoCs starting with Elba. Implying its Elba specific is misleading.
>
> Compatibles must be specific.
> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
> If this is SoC part it must match SoC. What is misleading in this? Why
> Pensando is different than all other SoCs (I am really getting tired
> everytime asking why people think their solution is special)?
>
> If this is not part of the SoC, then your commit msg is misleading.
> Maybe bindings as well, so rework it.
Yes, changed it back to 'amd,pensando-elba-ctrl' and fixed the dts, driver and commit message.
Regards,
Brad
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|