From: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx> Hello, An early error return from a remove callback is usally wrong. In the case of the spi-sprd driver it's not that critical because the skipped steps are mainly undoing the things that a successful runtime-resume would have done. Still it's cleaner to not exit early and not return an (mostly ignored) error value. The second patch converts to .remove_new (which is the motivation for this series). Best regards Uwe Uwe Kleine-König (2): spi: sprd: Don't skip cleanup in remove's error path spi: sprd: Convert to platform remove callback returning void drivers/spi/spi-sprd.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6 -- 2.39.1