Re: [PATCH] spi: spi-sn-f-ospi: fix white spaces and improve code formatting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 01, 2023 at 10:49:31AM +0530, dhruva gole wrote:
> On 27/02/23 19:39, Mark Brown wrote:
> > On Thu, Feb 23, 2023 at 03:59:18PM +0530, Dhruva Gole wrote:

> > > Allignment issues in all the macro definitions of this driver have been
> > > fixed for better asthetics

> > In what way?

> In my humble opinion, the spacing between the MACRO names

> and their values seemed a bit OFF. Like there lacked

> consistency for example:

> OSPI_PROT_MODE_QUAD			2
> OSPI_PROT_MODE_OCTAL		3

> Here we can see 3 is at a shorter length compared to 2 from their respective macros.

These look perfectly lined up for me.  I suspect you may have your tab
size set to something other than 8.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux