On Thu, Feb 23, 2023 at 03:59:18PM +0530, Dhruva Gole wrote:
> Fixes: 1b74dd64c861 ("spi: Add Socionext F_OSPI SPI flash controller driver")
This is clearly not a good fit for using Fixes.
> Allignment issues in all the macro definitions of this driver have been
> fixed for better asthetics
In what way?
> -#define OSPI_PROT_CTL_INDIR 0x00
> -#define OSPI_PROT_MODE_DATA_MASK GENMASK(31, 30)
> -#define OSPI_PROT_MODE_ALT_MASK GENMASK(29, 28)
> -#define OSPI_PROT_MODE_ADDR_MASK GENMASK(27, 26)
> -#define OSPI_PROT_MODE_CODE_MASK GENMASK(25, 24)
> -#define OSPI_PROT_MODE_SINGLE 0
> -#define OSPI_PROT_MODE_DUAL 1
> -#define OSPI_PROT_MODE_QUAD 2
> -#define OSPI_PROT_MODE_OCTAL 3
> +#define OSPI_PROT_CTL_INDIR 0x00
> +#define OSPI_PROT_MODE_DATA_MASK GENMASK(31, 30)
> +#define OSPI_PROT_MODE_ALT_MASK GENMASK(29, 28)
> +#define OSPI_PROT_MODE_ADDR_MASK GENMASK(27, 26)
> +#define OSPI_PROT_MODE_CODE_MASK GENMASK(25, 24)
> +#define OSPI_PROT_MODE_SINGLE 0
> +#define OSPI_PROT_MODE_DUAL 1
> +#define OSPI_PROT_MODE_QUAD 2
> +#define OSPI_PROT_MODE_OCTAL 3
As far as I can tell this is just removing all the intentation which
differentiates register, field and value - that looks like a clear step
back?
Attachment:
signature.asc
Description: PGP signature
