Re: [PATCH] spi: sh-msiof: Enforce fixed DTDL for R-Car H3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Thu, Jan 26, 2023 at 2:40 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > I have to disagree here. The docs say that other values are prohibited.
> > > IMO the driver should take care of valid values then. We should not rely
> > > on user provided input.
> >
> > Then we should make sure the user cannot override to an invalid value
> > through "renesas,dtdl" either?
>
> We do. The new flag is checked after sh_msiof_spi_parse_dt(), so any
> user input will be overwritten with the only value allowed.

OK.

> > To be clarified with Renesas?
>
> Frankly, I don't think it is worth the hazzle and just stick to the
> latest docs. Yes, they may be inaccurate for ES2.0 but what is the
> downside? Will it break things or is this just a little overhead?

Given the recent clarification from Renesas that this applies to all
revisions of R-Car H3 (ES1.0, ES2.0 and ES3.0):
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux