Re: [PATCH] spi: sh-msiof: Enforce fixed DTDL for R-Car H3

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Wolfram,

Thanks for your patch!

On Tue, Jan 24, 2023 at 8:47 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Documentation says only DTDL of 200 is allowed for this SoC.

Do you have a pointer to that?

> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> Tested with MSIOF0 on a Salvator-XS with R-Car H3 ES2.0 by creating a
> loopback with a wire.
>
>  drivers/spi/spi-sh-msiof.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
> index 9bca3d076f05..609f48ec84dd 100644
> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c
> @@ -30,12 +30,15 @@
>
>  #include <asm/unaligned.h>
>
> +#define SH_MSIOF_FLAG_FIXED_DTDL_200   BIT(0)

We already have "renesas,dtdl" to configure this from DT.
Iff this is really needed, perhaps it should be added to r8a77951.dtsi?

I suspect this is a leftover in the BSP from attempts to get MSIOF
working on R-Car H3 ES1.0 (which it never did for me, as CLK starts
and stops too soon, compared to MOSI/MISO).
On R-Car H3 ES2.0, everything works fine, without touching DTDL.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds