On Tue, Sep 27, 2022 at 06:01:39PM +0100, Mark Brown wrote: > On Tue, Sep 27, 2022 at 03:31:29PM +0200, Lukas Wunner wrote: > > On Tue, Sep 27, 2022 at 07:57:05PM +0800, Yang Yingliang wrote: > > > Do you mean to introduce two more proper wrappers to instead of > > > devm_spi_alloc_master/slave() ? > > > Honestly I don't think there's room for (or a need for) improvement here. > > The issue here is that we're trying to get rid of the master/slave > terminology. Converting drivers to use spi_controller everywhere in lieu of spi_master is fine, but drivers need to specify whether the spi_controller is a master or a slave and Geert's design is to specify that on allocation. Which makes sense because that's the moment the spi_controller comes to life, there's no earlier moment where one could specify the type. Thanks, Lukas