Re: [PATCH -next 0/6] spi: Switch to use devm_spi_alloc_master() in some drivers

[Lukas Wunner <lukas@xxxxxxxxx>]

On Wed, Sep 21, 2022 at 09:19:35PM +0800, Yang Yingliang wrote:
> On 2022/9/21 20:37, Mark Brown wrote:
> > On Wed, Sep 21, 2022 at 10:02:25AM +0800, Yang Yingliang wrote:
> > > On 2022/9/21 2:33, Mark Brown wrote:
> > > > If we're switching please update to the modern naming and use
> > > > "controller" rather than the old name.
> > > Do you mean to use spi_controller instead of spi_master? Something like
> > > this:
> > > 'struct spi_controller * ctlr = devm_spi_alloc_master();'
> > 
> > Or just use devm_spi_alloc_controller() directly.
> 
> Does __devm_spi_alloc_controller() need be changed to
> devm_spi_alloc_controller(), then use
> it, or just use __devm_spi_alloc_controller() directly.

Modern drivers only differentiate between master and slave on
allocation.  They use struct spi_controller instead of spi_master
and generally only call the spi_controller_*() functions (again,
except on allocation).  I think Mark wanted you to convert the
drivers so that they use struct spi_controller everywhere,
but that can be done in separate patches.

Thanks,

Lukas