On Tue, Sep 20, 2022 at 09:48:13PM +0800, Yang Yingliang wrote: > This patchset is trying to replace spi_alloc_master() with > devm_spi_alloc_master() in some spi drivers. With this helper, > spi_master_put() is called in devres_release_all() whenever > the device is unbound, so the spi_master_put() in error path > can be removed. > > Yang Yingliang (6): > spi: oc-tiny: Switch to use devm_spi_alloc_master() > spi: ath79: Switch to use devm_spi_alloc_master() > spi: omap-uwire: Switch to use devm_spi_alloc_master() > spi: ppc4xx: Switch to use devm_spi_alloc_master() > spi: sh-sci: Switch to use devm_spi_alloc_master() > spi: altera: Switch to use devm_spi_alloc_master() I'm withdrawing my objections to patches 1, 2 and 3: I failed to appreciate that these drivers use spi_bitbang_start(), which takes an extra reference on the controller. Sorry for the noise. Whole series is Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx> This pertains to v1 of the series, not v2 (which incorrectly uses __devm_spi_alloc_controller()). Thanks, Lukas