RE: [EXT] Re: [PATCH 1/2 v4] dt-bindings: dspi: added for semtech sx1301

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Best Regards
Jerry Huang

-----Original Message-----
From: Rob Herring <robh@xxxxxxxxxx> 
Sent: 2022年4月20日 21:30
To: Jerry Huang <jerry.huang@xxxxxxx>
Cc: Leo Li <leoyang.li@xxxxxxx>; shawnguo@xxxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; broonie@xxxxxxxxxx
Subject: [EXT] Re: [PATCH 1/2 v4] dt-bindings: dspi: added for semtech sx1301

Caution: EXT Email

On Wed, 20 Apr 2022 15:31:45 +0800, Changming Huang wrote:
> Add DT Binding doc for semtech sx1301
>
> Signed-off-by: Changming Huang <jerry.huang@xxxxxxx>
> ---
> changes in v4:
>   - rename example node, adjust description changes in v3:
>   - add the dt-bindings
>
>  .../bindings/spi/semtech,sx1301.yaml          | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/spi/semtech,sx1301.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml: properties:fsl,spi-sck-cs-delay: True is not of type 'object'
        hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
        from schema $id: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fvendor-props.yaml%23&amp;data=05%7C01%7Cjerry.huang%40nxp.com%7C4ceedab3225f4b6502ff08da22d1dcd5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637860581994654416%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=LJ%2FuvDhfQl3lgMd0zVeuX64bQWfLIAocCj5REq5A3so%3D&amp;reserved=0
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml: properties:fsl,spi-sck-cs-delay: More than one condition true in oneOf schema:
        {'description': 'Vendor specific properties must have a type and '
                        'description unless they have a defined, common '
                        'suffix.',
         'oneOf': [{'additionalProperties': False,
                    'description': 'A vendor boolean property can use "type: '
                                   'boolean"',
                    'properties': {'deprecated': True,
                                   'description': True,
                                   'type': {'const': 'boolean'}},
                    'required': ['type', 'description']},
                   {'additionalProperties': False,
                    'description': 'A vendor string property with exact values '
                                   'has an implicit type',
                    'oneOf': [{'required': ['enum']}, {'required': ['const']}],
                    'properties': {'const': {'type': 'string'},
                                   'deprecated': True,
                                   'description': True,
                                   'enum': {'items': {'type': 'string'}}},
                    'required': ['description']},
                   {'description': 'A vendor property needs a $ref to '
                                   'types.yaml',
                    'oneOf': [{'required': ['$ref']}, {'required': ['allOf']}],
                    'properties': {'$ref': {'pattern': 'types.yaml#/definitions/'},
                                   'allOf': {'items': [{'properties': {'$ref': {'pattern': 'types.yaml#/definitions/'}},
                                                        'required': ['$ref']}]}},
                    'required': ['description']},
                   {'description': 'A vendor property can have a $ref to a a '
                                   '$defs schema',
                    'properties': {'$ref': {'pattern': '^#/(definitions|$defs)/'}},
                    'required': ['$ref']}],
         'type': 'object'}
        hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
        from schema $id: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fvendor-props.yaml%23&amp;data=05%7C01%7Cjerry.huang%40nxp.com%7C4ceedab3225f4b6502ff08da22d1dcd5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637860581994654416%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=LJ%2FuvDhfQl3lgMd0zVeuX64bQWfLIAocCj5REq5A3so%3D&amp;reserved=0
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml: properties:fsl,spi-cs-sck-delay: True is not of type 'object'
        hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
        from schema $id: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fvendor-props.yaml%23&amp;data=05%7C01%7Cjerry.huang%40nxp.com%7C4ceedab3225f4b6502ff08da22d1dcd5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637860581994654416%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=LJ%2FuvDhfQl3lgMd0zVeuX64bQWfLIAocCj5REq5A3so%3D&amp;reserved=0
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml: properties:fsl,spi-cs-sck-delay: More than one condition true in oneOf schema:
        {'description': 'Vendor specific properties must have a type and '
                        'description unless they have a defined, common '
                        'suffix.',
         'oneOf': [{'additionalProperties': False,
                    'description': 'A vendor boolean property can use "type: '
                                   'boolean"',
                    'properties': {'deprecated': True,
                                   'description': True,
                                   'type': {'const': 'boolean'}},
                    'required': ['type', 'description']},
                   {'additionalProperties': False,
                    'description': 'A vendor string property with exact values '
                                   'has an implicit type',
                    'oneOf': [{'required': ['enum']}, {'required': ['const']}],
                    'properties': {'const': {'type': 'string'},
                                   'deprecated': True,
                                   'description': True,
                                   'enum': {'items': {'type': 'string'}}},
                    'required': ['description']},
                   {'description': 'A vendor property needs a $ref to '
                                   'types.yaml',
                    'oneOf': [{'required': ['$ref']}, {'required': ['allOf']}],
                    'properties': {'$ref': {'pattern': 'types.yaml#/definitions/'},
                                   'allOf': {'items': [{'properties': {'$ref': {'pattern': 'types.yaml#/definitions/'}},
                                                        'required': ['$ref']}]}},
                    'required': ['description']},
                   {'description': 'A vendor property can have a $ref to a a '
                                   '$defs schema',
                    'properties': {'$ref': {'pattern': '^#/(definitions|$defs)/'}},
                    'required': ['$ref']}],
         'type': 'object'}
        hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
        from schema $id: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fvendor-props.yaml%23&amp;data=05%7C01%7Cjerry.huang%40nxp.com%7C4ceedab3225f4b6502ff08da22d1dcd5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637860581994654416%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=LJ%2FuvDhfQl3lgMd0zVeuX64bQWfLIAocCj5REq5A3so%3D&amp;reserved=0
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml: ignoring, error in schema: properties: fsl,spi-cs-sck-delay
Documentation/devicetree/bindings/spi/semtech,sx1301.example.dts:22.11-21: Warning (reg_format): /example-0/spi@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/spi/semtech,sx1301.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/spi/semtech,sx1301.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/spi/semtech,sx1301.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/spi/semtech,sx1301.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/spi/semtech,sx1301.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/semtech,sx1301.example.dtb: example-0: spi@0:reg:0: [0] is too short
        From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
Documentation/devicetree/bindings/spi/semtech,sx1301.example.dtb:0:0: /example-0/spi@0: failed to match any schema with compatible: ['semtech,sx1301']

doc reference errors (make refcheckdocs):

See https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F&amp;data=05%7C01%7Cjerry.huang%40nxp.com%7C4ceedab3225f4b6502ff08da22d1dcd5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637860581994654416%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=WTdBfNjqzZBsnUBcRahew10JM84KqTEpI4bWNtHcKKU%3D&amp;reserved=0

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

[Jerry Huang] 
After correcting the name of compatible, I will run the command to check this binding file.
[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux