Best Regards Jerry Huang -----Original Message----- From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Sent: 2022年4月20日 20:06 To: Jerry Huang <jerry.huang@xxxxxxx>; broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Subject: [EXT] Re: [PATCH 1/2 v4] dt-bindings: dspi: added for semtech sx1301 Caution: EXT Email On 20/04/2022 09:31, Changming Huang wrote: > Add DT Binding doc for semtech sx1301 > > Signed-off-by: Changming Huang <jerry.huang@xxxxxxx> > --- > changes in v4: > - rename example node, adjust description changes in v3: > - add the dt-bindings > > .../bindings/spi/semtech,sx1301.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/spi/semtech,sx1301.yaml > > diff --git a/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml > b/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml > new file mode 100644 > index 000000000000..420fe8d23a1e > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > +cetree.org%2Fschemas%2Fspi%2Fsemtech%2Csx1301.yaml%23&data=05%7C0 > +1%7Cjerry.huang%40nxp.com%7C5fe40f1226344390810c08da22c629cc%7C686ea1 > +d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637860531744722352%7CUnknown%7CT > +WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC > +I6Mn0%3D%7C3000%7C%7C%7C&sdata=22w71yaEE9QdRNdIzaNr5NcfGbTVbh0lNB > +btch1n4e4%3D&reserved=0 > +$schema: > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cjerry.hua > +ng%40nxp.com%7C5fe40f1226344390810c08da22c629cc%7C686ea1d3bc2b4c6fa92 > +cd99c5c301635%7C0%7C0%7C637860531744722352%7CUnknown%7CTWFpbGZsb3d8ey > +JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30 > +00%7C%7C%7C&sdata=3XpGR4clLkzdKDh%2Fi26i4LQuuAYJ7E9%2Fv34lKn7%2Fa > +4o%3D&reserved=0 > + > +title: Semtech sx1301 SPI controller bindings This is still wrong. Please also answer Michael's comments. [Jerry Huang] I double checked the MikroBus devices, we used two MikcroBus devices: BLE P click: https://www.mikroe.com/ble-p-click BEE click: https://www.mikroe.com/bee-click Both of them are SPI interface connect to ls1028ardb through MiKcroBus interface. So the name "semtech sx1301" is not correct for this node. How about "mikroe, spi-dev" or any suggestion about it? Best regards, Krzysztof