On 31/01/22 01:55PM, Mark Brown wrote: > On Mon, Jan 31, 2022 at 05:15:08PM +0530, Pratyush Yadav wrote: > > The buffers passed in the data phase must be DMA-able. Programmers often > > don't realise this requirement and pass in buffers that reside on the > > stack. This can be hard to spot when reviewing code. Reject ops if their > > data buffer is on the stack to avoid this. > > Acked-by: Mark Brown <broonie@xxxxxxxxxx> Thanks. But seems like this is breaking build on arm-socfpga_defconfig. Let me take a look into it. > > > + /* Buffers must be DMA-able. */ > > + if (op->data.dir == SPI_MEM_DATA_IN && > > + object_is_on_stack(op->data.buf.in)) > > Might be worth a WARN_ON_ONCE() for debuggability? Okay, I'll add it. -- Regards, Pratyush Yadav Texas Instruments Inc.
Re: [PATCH] spi: spi-mem: check if data buffers are on stack
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] spi: spi-mem: check if data buffers are on stack
- From: Pratyush Yadav <p.yadav@xxxxxx>
- Date: Mon, 31 Jan 2022 22:37:11 +0530
- Cc: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>, Michael Walle <michael@xxxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Takahiro Kuwano <tkuw584924@xxxxxxxxx>, <linux-spi@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
- In-reply-to: <YffqNEzjIkApR1HS@sirena.org.uk>
- References: <20220131114508.1028306-1-p.yadav@ti.com> <YffqNEzjIkApR1HS@sirena.org.uk>
- References:
- [PATCH] spi: spi-mem: check if data buffers are on stack
- From: Pratyush Yadav
- Re: [PATCH] spi: spi-mem: check if data buffers are on stack
- From: Mark Brown
- [PATCH] spi: spi-mem: check if data buffers are on stack
- Prev by Date: Re: [PATCH v2] spi: pxa2xx_spi: Convert to use GPIO descriptors
- Next by Date: [PATCH v2] spi: st-ssc4: Covert to use GPIO descriptors
- Previous by thread: Re: [PATCH] spi: spi-mem: check if data buffers are on stack
- Next by thread: Re: [PATCH] spi: spi-mem: check if data buffers are on stack
- Index(es):
 |