On Mon, Jan 31, 2022 at 05:15:08PM +0530, Pratyush Yadav wrote: > The buffers passed in the data phase must be DMA-able. Programmers often > don't realise this requirement and pass in buffers that reside on the > stack. This can be hard to spot when reviewing code. Reject ops if their > data buffer is on the stack to avoid this. Acked-by: Mark Brown <broonie@xxxxxxxxxx> > + /* Buffers must be DMA-able. */ > + if (op->data.dir == SPI_MEM_DATA_IN && > + object_is_on_stack(op->data.buf.in)) Might be worth a WARN_ON_ONCE() for debuggability?
Attachment:
signature.asc
Description: PGP signature
