Re: [PATCH 5/5] spi: make remove callback a void function
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 5/5] spi: make remove callback a void function
- From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
- Date: Tue, 25 Jan 2022 11:29:03 +0100
- Cc: Andrew Lunn <andrew@xxxxxxx>, Gwendal Grignou <gwendal@xxxxxxxxxxxx>, Yasunari Takiguchi <Yasunari.Takiguchi@xxxxxxxx>, Claudius Heine <ch@xxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Nanyong Sun <sunnanyong@xxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Jaroslav Kysela <perex@xxxxxxxx>, Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>, Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>, linux-clk@xxxxxxxxxxxxxxx, Stefan Schmidt <stefan@xxxxxxxxxxxxxxxxxx>, Sidong Yang <realwakka@xxxxxxxxx>, libertas-dev@xxxxxxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, Antti Palosaari <crope@xxxxxx>, Jean Delvare <jdelvare@xxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx, Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>, Mark Tomlinson <mark.tomlinson@xxxxxxxxxxxxxxxxxxx>, James Schulman <james.schulman@xxxxxxxxxx>, Kamlesh Gurudasani <kamlesh.gurudasani@xxxxxxxxx>, Jingoo Han <jingoohan1@xxxxxxxxx>, Zhang Qilong <zhangqilong3@xxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, Michael Walle <michael@xxxxxxxx>, Noralf Trønnes <noralf@xxxxxxxxxxx>, kernel@xxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Vladimir Oltean <olteanv@xxxxxxxxx>, linux-wpan@xxxxxxxxxxxxxxx, Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Dan Robertson <dan@xxxxxxxxxxxxxxx>, Markuss Broks <markuss.broks@xxxxxxxxx>, Lucas Tanure <tanureal@xxxxxxxxxxxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, David Rhodes <david.rhodes@xxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Solomon Peachy <pizza@xxxxxxxxxxxx>, Marek Behún <kabel@xxxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>, Emmanuel Gil Peyrot <linkmauve@xxxxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Bartosz Golaszewski <brgl@xxxxxxxx>, Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>, Minghao Chi <chi.minghao@xxxxxxxxxx>, Jon Hunter <jonathanh@xxxxxxxxxx>, dingsenjie <dingsenjie@xxxxxxxxxx>, Heiko Schocher <hs@xxxxxxx>, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Matt Kline <matt@xxxxxxxxxxxxx>, Woojung Huh <woojung.huh@xxxxxxxxxxxxx>, Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>, Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>, Mike Looijmans <mike.looijmans@xxxxxxxx>, Ronald Tschalär <ronald@xxxxxxxxxxxxx>, Daniel Thompson <daniel.thompson@xxxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, linux-can@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Hans de Goede <hdegoede@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Davidlohr Bueso <dbueso@xxxxxxx>, UNGLinuxDriver@xxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, linux-integrity@xxxxxxxxxxxxxxx, Jonathan Cameron <jic23@xxxxxxxxxx>, Heiner Kallweit <hkallweit1@xxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, Michael Turquette <mturquette@xxxxxxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, Nuno Sá <nuno.sa@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Wei Yongjun <weiyongjun1@xxxxxxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>, Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>, linux-rtc@xxxxxxxxxxxxxxx, Marcus Folkesson <marcus.folkesson@xxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Aditya Srivastava <yashsri421@xxxxxxxxx>, Varka Bhadram <varkabhadram@xxxxxxxxx>, wengjianfeng <wengjianfeng@xxxxxxxxxx>, linux-input@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>, Mark Greer <mgreer@xxxxxxxxxxxxxxx>, Mark Gross <markgross@xxxxxxxxxx>, Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>, linux-fbdev@xxxxxxxxxxxxxxx, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Stefan Mätje <stefan.maetje@xxxxxx>, linux-hwmon@xxxxxxxxxxxxxxx, Felipe Balbi <balbi@xxxxxxxxxx>, Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@xxxxxxxxx>, Support Opensource <support.opensource@xxxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, linux-mmc@xxxxxxxxxxxxxxx, Liam Girdwood <lgirdwood@xxxxxxxxx>, Julia Lawall <Julia.Lawall@xxxxxxxx>, Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>, patches@xxxxxxxxxxxxxxxxxxxxx, Kent Gustavsson <kent@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Alexander Aring <alex.aring@xxxxxxxxx>, Jiri Prchal <jiri.prchal@xxxxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Emma Anholt <emma@xxxxxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>, Alexandru Ardelean <ardeleanalex@xxxxxxxxx>, Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>, Torin Cooper-Bennun <torin@xxxxxxxxxxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, linux-leds@xxxxxxxxxxxxxxx, Eric Piel <eric.piel@xxxxxxxxxxxxxxxx>, Stephan Gerhold <stephan@xxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Thomas Kopp <thomas.kopp@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Vivien Didelot <vivien.didelot@xxxxxxxxx>, platform-driver-x86@xxxxxxxxxxxxxxx, Stefan Wahren <stefan.wahren@xxxxxxxx>, Xue Liu <liuxuenetmail@xxxxxxxxx>, David Lechner <david@xxxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Manivannan Sadhasivam <mani@xxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxx>, Rui Miguel Silva <rmfrfs@xxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, Fabio Estevam <festevam@xxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, Yang Shen <shenyang39@xxxxxxxxxx>, Thomas Zimmermann <tzimmermann@xxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Cai Huoqing <caihuoqing@xxxxxxxxx>, Daniel Mack <daniel@xxxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Colin Ian King <colin.king@xxxxxxxxx>, Helge Deller <deller@xxxxxx>, Alan Ott <alan@xxxxxxxxxxx>
- In-reply-to: <20220125094759.000019c5@Huawei.com>
- References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> <20220125094759.000019c5@Huawei.com>
[Dropped a few people from Cc that are not reachable (Harry Morris,
Charles-Antoine Couret, Marco Felsch)]
On Tue, Jan 25, 2022 at 09:47:59AM +0000, Jonathan Cameron wrote:
> On Sun, 23 Jan 2022 18:52:01 +0100
> Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
> > The value returned by an spi driver's remove function is mostly ignored.
> > (Only an error message is printed if the value is non-zero that the
> > error is ignored.)
> >
> > So change the prototype of the remove function to return no value. This
> > way driver authors are not tempted to assume that passing an error to
> > the upper layer is a good idea. All drivers are adapted accordingly.
> > There is no intended change of behaviour, all callbacks were prepared to
> > return 0 before.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> For iio drivers.
>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> As you mention in the cover letter we'll be wanting an immutable
> branch somewhere to pull into subsystem trees.
>
> Soon is good if possible as otherwise we'll end up with a bunch of merge
> conflicts getting resolved in next.
Yes, I considered creating a tag to pull already when sending out this
series, but I guessed delaying that a little bit to give people the
opportunity to ack would be a good idea.
@broonie: Do you think this change is a good idea? Would you require
some more acks for the preparatory patches? I had hoped to get Acks from
the corresponding maintainers, maybe they are busy and missed this
series as I put them on Cc: only. I promoted them to To: in this mail.
Or is it too ambitious to get this in during the next merge window?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|