Re: [PATCH 5/5] spi: make remove callback a void function
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 5/5] spi: make remove callback a void function
- From: Stefan Schmidt <stefan@xxxxxxxxxxxxxxxxxx>
- Date: Tue, 25 Jan 2022 10:44:28 +0100
- Cc: Marek Behún <kabel@xxxxxxxxxx>, Peter Huewe <peterhuewe@xxxxxx>, Jarkko Sakkinen <jarkko@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Michael Turquette <mturquette@xxxxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Bartosz Golaszewski <brgl@xxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Markuss Broks <markuss.broks@xxxxxxxxx>, Emma Anholt <emma@xxxxxxxxxxxxxxxxxx>, David Lechner <david@xxxxxxxxxxxxxx>, Kamlesh Gurudasani <kamlesh.gurudasani@xxxxxxxxx>, Noralf Trønnes <noralf@xxxxxxxxxxx>, Jean Delvare <jdelvare@xxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Dan Robertson <dan@xxxxxxxxxxxxxxx>, Jonathan Cameron <jic23@xxxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>, Marcus Folkesson <marcus.folkesson@xxxxxxxxx>, Kent Gustavsson <kent@xxxxxxxxxx>, Rui Miguel Silva <rmfrfs@xxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Yasunari Takiguchi <Yasunari.Takiguchi@xxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Charles-Antoine Couret <charles-antoine.couret@xxxxxxxxxxxx>, Antti Palosaari <crope@xxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Support Opensource <support.opensource@xxxxxxxxxxx>, Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>, Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Eric Piel <eric.piel@xxxxxxxxxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Manivannan Sadhasivam <mani@xxxxxxxxxx>, Thomas Kopp <thomas.kopp@xxxxxxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Vivien Didelot <vivien.didelot@xxxxxxxxx>, Vladimir Oltean <olteanv@xxxxxxxxx>, Woojung Huh <woojung.huh@xxxxxxxxxxxxx>, UNGLinuxDriver@xxxxxxxxxxxxx, Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>, Alexander Aring <alex.aring@xxxxxxxxx>, Harry Morris <h.morris@xxxxxxxxxxx>, Varka Bhadram <varkabhadram@xxxxxxxxx>, Xue Liu <liuxuenetmail@xxxxxxxxx>, Alan Ott <alan@xxxxxxxxxxx>, Heiner Kallweit <hkallweit1@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxx>, Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>, Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>, Solomon Peachy <pizza@xxxxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>, Mark Greer <mgreer@xxxxxxxxxxxxxxx>, Benson Leung <bleung@xxxxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Mark Gross <markgross@xxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Felipe Balbi <balbi@xxxxxxxxxx>, Daniel Thompson <daniel.thompson@xxxxxxxxxx>, Jingoo Han <jingoohan1@xxxxxxxxx>, Helge Deller <deller@xxxxxx>, James Schulman <james.schulman@xxxxxxxxxx>, David Rhodes <david.rhodes@xxxxxxxxxx>, Lucas Tanure <tanureal@xxxxxxxxxxxxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Nuno Sá <nuno.sa@xxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Daniel Mack <daniel@xxxxxxxxxx>, Thomas Zimmermann <tzimmermann@xxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Stephan Gerhold <stephan@xxxxxxxxxxx>, Alexandru Ardelean <ardeleanalex@xxxxxxxxx>, Mike Looijmans <mike.looijmans@xxxxxxxx>, Gwendal Grignou <gwendal@xxxxxxxxxxxx>, Cai Huoqing <caihuoqing@xxxxxxxxx>, Minghao Chi <chi.minghao@xxxxxxxxxx>, Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>, Julia Lawall <Julia.Lawall@xxxxxxxx>, Ronald Tschalär <ronald@xxxxxxxxxxxxx>, Marco Felsch <m.felsch@xxxxxxxxxxxxxx>, Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>, Emmanuel Gil Peyrot <linkmauve@xxxxxxxxxxxx>, Jon Hunter <jonathanh@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Heiko Schocher <hs@xxxxxxx>, Fabio Estevam <festevam@xxxxxxxxx>, Colin Ian King <colin.king@xxxxxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>, Matt Kline <matt@xxxxxxxxxxxxx>, Torin Cooper-Bennun <torin@xxxxxxxxxxxxxxxxxx>, Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>, Stefan Mätje <stefan.maetje@xxxxxx>, Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>, Wei Yongjun <weiyongjun1@xxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Nanyong Sun <sunnanyong@xxxxxxxxxx>, Yang Shen <shenyang39@xxxxxxxxxx>, dingsenjie <dingsenjie@xxxxxxxxxx>, Aditya Srivastava <yashsri421@xxxxxxxxx>, Stefan Wahren <stefan.wahren@xxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Michael Walle <michael@xxxxxxxx>, Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, wengjianfeng <wengjianfeng@xxxxxxxxxx>, Sidong Yang <realwakka@xxxxxxxxx>, Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@xxxxxxxxx>, Zhang Qilong <zhangqilong3@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Mark Tomlinson <mark.tomlinson@xxxxxxxxxxxxxxxxxxx>, Davidlohr Bueso <dbueso@xxxxxxx>, Claudius Heine <ch@xxxxxxx>, Jiri Prchal <jiri.prchal@xxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-integrity@xxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-hwmon@xxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, patches@xxxxxxxxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-wpan@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, libertas-dev@xxxxxxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-rtc@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx
- In-reply-to: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de>
- References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0
Hello.
On 23.01.22 18:52, Uwe Kleine-König wrote:
The value returned by an spi driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)
So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
[...]
drivers/net/ieee802154/adf7242.c | 4 +---
drivers/net/ieee802154/at86rf230.c | 4 +---
drivers/net/ieee802154/ca8210.c | 6 ++----
drivers/net/ieee802154/cc2520.c | 4 +---
drivers/net/ieee802154/mcr20a.c | 4 +---
drivers/net/ieee802154/mrf24j40.c | 4 +---
[...]
For the ieee802154 drivers:
Acked-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxxxxx>
regards
Stefan Schmidt
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|