> -----Original Message----- > From: Kuldeep Singh > Sent: 2021年8月20日 16:49 > To: Bough Chen <haibo.chen@xxxxxxx>; Ashish Kumar > <ashish.kumar@xxxxxxx>; yogeshgaur.83@xxxxxxxxx; broonie@xxxxxxxxxx > Cc: linux-spi@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Bough Chen > <haibo.chen@xxxxxxx> > Subject: RE: [EXT] [PATCH 2/4] spi: spi-nxp-fspi: change the default lut index > > Hi Haibo, > > > -----Original Message----- > > From: haibo.chen@xxxxxxx <haibo.chen@xxxxxxx> > > Sent: Friday, August 20, 2021 1:14 PM > > To: Ashish Kumar <ashish.kumar@xxxxxxx>; yogeshgaur.83@xxxxxxxxx; > > broonie@xxxxxxxxxx > > Cc: linux-spi@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Bough > > Chen <haibo.chen@xxxxxxx> > > Subject: [EXT] [PATCH 2/4] spi: spi-nxp-fspi: change the default lut > > index > > > > Caution: EXT Email > > > > From: Haibo Chen <haibo.chen@xxxxxxx> > > > > The fspi dynamic lut use the last lut for all IPS operations, the > > imx8ulp only supports 15 luts, so change the last lut index from > > 31 to 15. > > > > Signed-off-by: Han Xu <han.xu@xxxxxxx> > > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx> > > --- > > drivers/spi/spi-nxp-fspi.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c > > index 1eecf20f1dab..a764eb475aed 100644 > > --- a/drivers/spi/spi-nxp-fspi.c > > +++ b/drivers/spi/spi-nxp-fspi.c > > @@ -63,9 +63,9 @@ > > /* > > * The driver only uses one single LUT entry, that is updated on > > * each call of exec_op(). Index 0 is preset at boot with a basic > > - * read operation, so let's use the last entry (31). > > + * read operation, so let's use the last entry (15). > > One nitpick: > Last LUT entry is still 31 for all platforms except imx8ulp which has 15. > QSPI driver uses last lut entry 15 whereas 15 will be middle entry for flexspi(in > general). > > The word 'last' in current comment does not seem appropriate for all cases. > Maybe you can update comment for ex: > "Index 0 is present at boot with a basic read operation and last lut entry is 31. > Some platforms like imx8ulp supports 16 lut entries and therefore, use lut index > entry 15." > > Other than that, > Reviewed-by: Kuldeep Singh <kuldeep.singh@xxxxxxx> Hi Kuldeep, Thanks for your suggestion. I will do that. Best Regards Haibo Chen > > Regards > Kuldeep
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
