Re: [PATCH v1] spi: fix client driver can't register success when use GPIO as CS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在 2021/5/8 上午5:33, Linus Walleij 写道:
On Fri, May 7, 2021 at 9:11 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:

It can’t be done due to differences of the expectations from them.
Your patch breaks OF as far as I understand. Linus?
It looks to me like it would break OF.

commit 766c6b63aa044e84b045803b40b14754d69a2a1d
"spi: fix client driver breakages when using GPIO descriptors"
passes enable1 to gpiod_set_value_cansleep() expecting
gpiolib to handle polarity.

If this should be changed, Sven van Asbroeck really needs
to look at it first.

But I think Andy's approach is the best.

Ok, agree, i check the relative patches, They do respond to different situations,

Andy,When do you send out your patch to fix this problem?


Yours,
Linus Walleij

--
Best Regards!
Xin Hao




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux