Re: [PATCH v1] spi: fix client driver can't register success when use GPIO as CS

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, May 7, 2021 at 9:11 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:

> It can’t be done due to differences of the expectations from them.
> Your patch breaks OF as far as I understand. Linus?

It looks to me like it would break OF.

commit 766c6b63aa044e84b045803b40b14754d69a2a1d
"spi: fix client driver breakages when using GPIO descriptors"
passes enable1 to gpiod_set_value_cansleep() expecting
gpiolib to handle polarity.

If this should be changed, Sven van Asbroeck really needs
to look at it first.

But I think Andy's approach is the best.

Yours,
Linus Walleij