Re: [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support

[zhengxunli@xxxxxxxxxxx]

Hi Mark,

Thanks for your reply.

"Mark Brown" <broonie@xxxxxxxxxx> wrote on 2021/04/27 上午 12:53:58:

> "Mark Brown" <broonie@xxxxxxxxxx> 
> 2021/04/27 上午 12:54
> 
> To
> 
> "Zhengxun Li" <zhengxunli@xxxxxxxxxxx>, 
> 
> cc
> 
> linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, 
> tudor.ambarus@xxxxxxxxxxxxx, miquel.raynal@xxxxxxxxxxx, 
jaimeliao@xxxxxxxxxxx
> 
> Subject
> 
> Re: [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support
> 
> On Tue, Apr 20, 2021 at 02:29:39PM +0800, Zhengxun Li wrote:
> 
> > -   return spi_mem_default_supports_op(mem, op);
> > +   all_false = !op->cmd.dtr && !op->addr.dtr && !op->dummy.dtr &&
> > +          !op->data.dtr;
> > +
> > +   if (all_false)
> 
> This feels like we might want a spi_mem_op_is_dtr() helper?  I can see
> other controllers wanting a similar check.

Yes, since spi_mem_default_supports_op does not support any dtr 
operations,
we need spi_mem_op_is dtr() to help us check dtr operations.

Thanks,
Zhengxun Li


CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information 
and/or personal data, which is protected by applicable laws. Please be 
reminded that duplication, disclosure, distribution, or use of this e-mail 
(and/or its attachments) or any part thereof is prohibited. If you receive 
this e-mail in error, please notify us immediately and delete this mail as 
well as its attachment(s) from your system. In addition, please be 
informed that collection, processing, and/or use of personal data is 
prohibited unless expressly permitted by personal data protection laws. 
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================



============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================