On Tue, Mar 23, 2021 at 12:04:34PM -0700, Dmitry Torokhov wrote: > On Tue, Mar 23, 2021 at 05:36:06PM +0000, Mark Brown wrote: > No it is ordering issue. I do not have a proven real-life example for > SPI, but we do have one for I2C: > https://lore.kernel.org/linux-devicetree/20210305041236.3489-7-jeff@xxxxxxxxxxx/ TBH that looks like a fairly standard case where you probably don't want to be using devm for the interrupts in the first place. Leaving the interrupts live after the bus thinks it freed the device doesn't seem like the best idea, I'm not sure I'd expect that to work reliably when the device tries to call into the bus code to interact with the device that the bus thought was already freed anyway. If we want this to work reliably it really feels like we should have two remove callbacks in the driver core doing this rather than open coding in every single bus which is what we'd need to do - this is going to affect any bus that does anything other than just call the device's remove() callback. PCI looks like it might have issues too for example, and platform does as well and those were simply the first two buses I looked at. Possibly we want a driver core callback which is scheduled via devm (remove_devm(), cleanup() or something). We'd still need to move things about in all the buses but it seems preferable to do it that way rather than open coding opening a group and the comments about what's going on and the ordering requirements everywhere, it's a little less error prone going forward. > Note how dev_pm_domain_detach() jumped ahead of everything, and > strictly speaking past this point we can no longer guarantee that we can > access the chip and disable it. Frankly it looks like the PM domain stuff shouldn't be in the probe() and remove() paths at all and this has been bogusly copies from other buses, it should be in the device registration paths. The device is in the domain no matter what's going on with binding it. Given how generic code is I'm not even sure why it's in the buses.
Attachment:
signature.asc
Description: PGP signature
