On Mon, Feb 15, 2021 at 03:22:38PM +0200, Andy Shevchenko wrote:
> On Sun, Feb 14, 2021 at 10:57:46PM +0800, Dejin Zheng wrote:
> > Call to 'pci_free_irq_vectors()' are missing both in the error handling
> > path of the probe function, and in the remove function. So add them.
>
> I'm wondering if you noticed that it's done by pcim_* API.
> Perhaps you can introduce pcim_alloc_irq_vectors() or so and do not add these
> calls at all?
Andy, Thanks for your reminder, You mean introduce
pcim_alloc_irq_vectors() as like pcim_set_mwi() and free irq vectors by
pcim_release()?
>
> > Fixes: 64e02cb0bdfc7c ("spi: pca2xx-pci: Allow MSI")
>
> No, it doesn't fix anything.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- From: Dejin Zheng <zhengdejin5@xxxxxxxxx>
- Date: Mon, 15 Feb 2021 22:55:32 +0800
- Cc: daniel@xxxxxxxxxx, haojian.zhuang@xxxxxxxxx, robert.jarzmik@xxxxxxx, broonie@xxxxxxxxxx, jan.kiszka@xxxxxxxxxxx, jarkko.nikula@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <YCp1nh2ZEBvvB+lC@smile.fi.intel.com>
- References: <20210214145746.602770-1-zhengdejin5@gmail.com> <YCp1nh2ZEBvvB+lC@smile.fi.intel.com>
- References:
- Prev by Date: Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- Next by Date: Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- Previous by thread: Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- Next by thread: [PATCH v2] spi: pxa2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- Index(es):
 |