On Sun, Feb 14, 2021 at 10:57:46PM +0800, Dejin Zheng wrote:
> Call to 'pci_free_irq_vectors()' are missing both in the error handling
> path of the probe function, and in the remove function. So add them.
I'm wondering if you noticed that it's done by pcim_* API.
Perhaps you can introduce pcim_alloc_irq_vectors() or so and do not add these
calls at all?
> Fixes: 64e02cb0bdfc7c ("spi: pca2xx-pci: Allow MSI")
No, it doesn't fix anything.
--
With Best Regards,
Andy Shevchenko
Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Mon, 15 Feb 2021 15:22:38 +0200
- Cc: daniel@xxxxxxxxxx, haojian.zhuang@xxxxxxxxx, robert.jarzmik@xxxxxxx, broonie@xxxxxxxxxx, jan.kiszka@xxxxxxxxxxx, jarkko.nikula@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <20210214145746.602770-1-zhengdejin5@gmail.com>
- Ironport-sdr: cw0SpZJkWfXf4g7/3QC6uHGl92mHR9dAles+kJiIa7OQQIWSTcTncjwQCD5SeCXB1xDIp8qrvI PcS139KcfBDg==
- Ironport-sdr: Q92VLC8ChvVQp9ZTerRdIUQPLKHA+TrtS3HUJ9mgc6H5DzaPi59pZB7OXkoGrivf8EqbJjOAls AK0bhyIDQOVQ==
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20210214145746.602770-1-zhengdejin5@gmail.com>
- Follow-Ups:
- References:
- Prev by Date: Re: [PATCH v2] spi: pxa2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- Next by Date: Re: [PATCH v2] spi: pxa2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- Previous by thread: Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- Next by thread: Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'
- Index(es):
 |