Re: [PATCH] spi: sprd: fix reference leak in sprd_spi_remove

[Chunyan Zhang <zhang.lyra@xxxxxxxxx>]

On Fri, 6 Nov 2020 at 09:39, Zhang Qilong <zhangqilong3@xxxxxxxxxx> wrote:
>
> pm_runtime_get_sync will increment pm usage counter even it
> failed. Forgetting to pm_runtime_put_noidle will result in
> reference leak in sprd_spi_remove, so we should fix it.
>
> Fixes: e7d973a31c24b ("spi: sprd: Add SPI driver for Spreadtrum SC9860")
> Signed-off-by: Zhang Qilong <zhangqilong3@xxxxxxxxxx>

Acked-by: Chunyan Zhang <zhang.lyra@xxxxxxxxx>

Thanks,
Chunyan

> ---
>  drivers/spi/spi-sprd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c
> index 635738f54c73..b41a75749b49 100644
> --- a/drivers/spi/spi-sprd.c
> +++ b/drivers/spi/spi-sprd.c
> @@ -1010,6 +1010,7 @@ static int sprd_spi_remove(struct platform_device *pdev)
>
>         ret = pm_runtime_get_sync(ss->dev);
>         if (ret < 0) {
> +               pm_runtime_put_noidle(ss->dev);
>                 dev_err(ss->dev, "failed to resume SPI controller\n");
>                 return ret;
>         }
> --
> 2.17.1
>