Re: [PATCH] spi: atmel-quadspi: Disable clock in probe error path

[<Tudor.Ambarus@xxxxxxxxxxxxx>]

On 11/9/20 12:41 AM, Lukas Wunner wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> If the call to of_device_get_match_data() fails on probe of the Atmel
> QuadSPI driver, the clock "aq->pclk" is erroneously not unprepared and
> disabled.  Fix it.
> 
> Fixes: 2e5c88887358 ("spi: atmel-quadspi: add support for sam9x60 qspi controller")
> Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v5.1+
> Cc: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>

Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>

Thanks!

> ---
>  drivers/spi/atmel-quadspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> index 8c009c175f2c..b44521d4a245 100644
> --- a/drivers/spi/atmel-quadspi.c
> +++ b/drivers/spi/atmel-quadspi.c
> @@ -594,7 +594,7 @@ static int atmel_qspi_probe(struct platform_device *pdev)
>         if (!aq->caps) {
>                 dev_err(&pdev->dev, "Could not retrieve QSPI caps\n");
>                 err = -EINVAL;
> -               goto exit;
> +               goto disable_pclk;
>         }
> 
>         if (aq->caps->has_qspick) {
> --
> 2.28.0
>