Re: [PATCH] spi: synquacer: Disable clock in probe error path

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Mon, Nov 9, 2020 at 12:52 AM Lukas Wunner <lukas@xxxxxxxxx> wrote:
>
> If the calls to platform_get_irq() or devm_request_irq() fail on probe
> of the SynQuacer SPI driver, the clock "sspi->clk" is erroneously not
> unprepared and disabled.
>
> If the clock rate "master->max_speed_hz" cannot be determined, the same
> happens and in addition the spi_master struct is not freed.

Wouldn't be better to switch over devm_add_action_or_reset() in such cases?

-- 
With Best Regards,
Andy Shevchenko