Re: [PATCH] spi: stm32: fix reference leak in stm32_spi_resume

[Alain Volmat <alain.volmat@xxxxxx>]

Hi Zhang,

thanks for the patch.

Reviewed-by: Alain Volmat <alain.volmat@xxxxxx>

Alain

On Fri, Nov 06, 2020 at 09:52:17AM +0800, Zhang Qilong wrote:
> pm_runtime_get_sync will increment pm usage counter even it
> failed. Forgetting to pm_runtime_put_noidle will result in
> reference leak in stm32_spi_resume, so we should fix it.
> 
> Fixes: db96bf976a4fc ("spi: stm32: fixes suspend/resume management")
> Signed-off-by: Zhang Qilong <zhangqilong3@xxxxxxxxxx>
> ---
>  drivers/spi/spi-stm32.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
> index 2cc850eb8922..471dedf3d339 100644
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -2062,6 +2062,7 @@ static int stm32_spi_resume(struct device *dev)
>  
>  	ret = pm_runtime_get_sync(dev);
>  	if (ret < 0) {
> +		pm_runtime_put_noidle(dev);
>  		dev_err(dev, "Unable to power device:%d\n", ret);
>  		return ret;
>  	}
> -- 
> 2.17.1
>