On Wed, Nov 04, 2020 at 12:54:31PM -0800, Saravana Kannan wrote: > From: Daniel Mentz <danielmentz@xxxxxxxxxx> > > This allows the fw_devlink feature to work for spi devices > too. This avoids unnecessary probe deferrals related to spi devices and > improves suspend/resume ordering for spi devices when fw_devlink=on. > of_node_get(nc); > spi->dev.of_node = nc; > + spi->dev.fwnode = of_fwnode_handle(nc); Why is this a manual step in an individual subsystem rather than something done in the driver core - when would we not want to have the fwnode correspond to the of_node, and wouldn't that just be a case of checking to see if there is a fwnode already set and only initializing if not anyway?
Attachment:
signature.asc
Description: PGP signature
