On Wed, Oct 21, 2020 at 10:55:04AM +0800, Ramuthevar,Vadivel MuruganX wrote: > Add multiple chipselect support for Intel LGM SoCs, > currently QSPI-NOR and QSPI-NAND supported. > + if (ddata->hwcaps_mask & CQSPI_SUPPORTS_MULTI_CHIPSELECT) > + master->num_chipselect = cqspi->num_chipselect; I'm not seeing anywhere else where we reference num_chipselect in this patch - we parse the value, set it in the SPI controller and then never otherwise use it? This makes me wonder if the property is really mandatory. If it is then there should be something in the binding document saying that it's required when the compatible is your new compatible string, that way the validation can verify that the property is present in DTs including this controller.
Attachment:
signature.asc
Description: PGP signature
