Re: [PATCH 0/4] dt-bindings: additional/unevaluatedProperties clean-ups
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 0/4] dt-bindings: additional/unevaluatedProperties clean-ups
- From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
- Date: Tue, 6 Oct 2020 09:25:06 +0100
- Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Chanwoo Choi <cw00.choi@xxxxxxxxxxx>, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, dmaengine@xxxxxxxxxxxxxxx, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Heiner Kallweit <hkallweit1@xxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Jason Cooper <jason@xxxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jonathan Cameron <jic23@xxxxxxxxxx>, Krzysztof Kozlowski <krzk@xxxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>, Sebastian Reichel <sre@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Viresh Kumar <vireshk@xxxxxxxxxx>, Vivien Didelot <vivien.didelot@xxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Zhang Rui <rui.zhang@xxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, linux-hwmon@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-pwm@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-rtc@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-watchdog@xxxxxxxxxxxxxxx
- In-reply-to: <20201005183830.486085-1-robh@kernel.org>
- References: <20201005183830.486085-1-robh@kernel.org>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
On 05/10/2020 19:38, Rob Herring wrote:
The default behavior for json-schema is any unknown property is allowed.
T
hat is generally not the behavior we want for DT. In order to disallow
extra properties, schemas need to define 'additionalProperties: false'
typically. Ideally, we'd just add that automatically with the tools, but
there are some exceptions so only making things explicit everywhere
really works. Missing 'additionalProperties' or 'unevaluatedProperties'
has been a constant source of review comments, so a meta-schema check is
really needed here.
Documentation/devicetree/bindings/nvmem/nvmem.yaml | 2 ++
.../devicetree/bindings/nvmem/qcom,qfprom.yaml | 2 ++
for nvmem parts,
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
thanks,
--srini
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|