Re: [PATCH 2/4] dt-bindings: Use 'additionalProperties' instead of 'unevaluatedProperties'

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

Subject: Re: [PATCH 2/4] dt-bindings: Use 'additionalProperties' instead of 'unevaluatedProperties'

From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Date: Mon, 5 Oct 2020 22:33:00 +0200

Cc: devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Chanwoo Choi <cw00.choi@xxxxxxxxxxx>, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, dmaengine@xxxxxxxxxxxxxxx, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Heiner Kallweit <hkallweit1@xxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Jason Cooper <jason@xxxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jonathan Cameron <jic23@xxxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>, Sebastian Reichel <sre@xxxxxxxxxx>, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Viresh Kumar <vireshk@xxxxxxxxxx>, Vivien Didelot <vivien.didelot@xxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Zhang Rui <rui.zhang@xxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, linux-hwmon@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-pwm@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-rtc@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-watchdog@xxxxxxxxxxxxxxx

In-reply-to: <20201005183830.486085-3-robh@kernel.org>

References: <20201005183830.486085-1-robh@kernel.org> <20201005183830.486085-3-robh@kernel.org>

User-agent: Mutt/1.9.4 (2018-02-28)

On Mon, Oct 05, 2020 at 01:38:28PM -0500, Rob Herring wrote:
> In cases where we don't reference another schema, 'additionalProperties'
> can be used instead. This is preferred for now as 'unevaluatedProperties'
> support isn't implemented yet.
> 
> In a few cases, this means adding some missing property definitions of
> which most are for SPI bus properties. 'unevaluatedProperties' is not going
> to work for the SPI bus properties anyways as they are evaluated from the
> parent node, not the SPI child node.
> 
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof