Re: [PATCH 1/6] spi: fsl-dspi: Use devm_spi_register_controller()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 22, 2020 at 11:32:23AM +0200, Sascha Hauer wrote:

> @@ -1440,9 +1440,6 @@ static int dspi_remove(struct platform_device *pdev)
>  	struct spi_controller *ctlr = platform_get_drvdata(pdev);
>  	struct fsl_dspi *dspi = spi_controller_get_devdata(ctlr);
>  
> -	/* Disconnect from the SPI framework */
> -	spi_unregister_controller(dspi->ctlr);
> -
>  	/* Disable RX and TX */
>  	regmap_update_bits(dspi->regmap, SPI_MCR,
>  			   SPI_MCR_DIS_TXF | SPI_MCR_DIS_RXF,

Is this fix safe - what happens if we start another transaction between
disabling RX/TX and the unregistration taking effect?  Similar concerns
apply to some of the other patches.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux