RE: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support

[Kuldip Dwivedi <kuldip.dwivedi@xxxxxxxxxxxxxxxx>]

> -----Original Message-----
> From: Ashish Kumar <ashish.kumar@xxxxxxx>
> Sent: Friday, September 11, 2020 7:03 PM
> To: Mark Brown <broonie@xxxxxxxxxx>
> Cc: kuldip dwivedi <kuldip.dwivedi@xxxxxxxxxxxxxxxx>; Yogesh Gaur
> <yogeshgaur.83@xxxxxxxxx>; linux-spi@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Varun Sethi <V.Sethi@xxxxxxx>; Arokia Samy
> <arokia.samy@xxxxxxx>; Ard Biesheuvel <Ard.Biesheuvel@xxxxxxx>; Samer
El-
> Haj-Mahmoud <Samer.El-Haj-Mahmoud@xxxxxxx>; Paul Yang
> <Paul.Yang@xxxxxxx>
> Subject: RE: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
>
> Hi Mark,
>
> > -----Original Message-----
> > From: Mark Brown <broonie@xxxxxxxxxx>
> > Sent: Friday, September 11, 2020 6:04 PM
> > To: Ashish Kumar <ashish.kumar@xxxxxxx>
> > Cc: kuldip dwivedi <kuldip.dwivedi@xxxxxxxxxxxxxxxx>; Yogesh Gaur
> > <yogeshgaur.83@xxxxxxxxx>; linux-spi@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; Varun Sethi <V.Sethi@xxxxxxx>; Arokia Samy
> > <arokia.samy@xxxxxxx>; Ard Biesheuvel <Ard.Biesheuvel@xxxxxxx>; Samer
> > El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@xxxxxxx>; Paul Yang
> > <Paul.Yang@xxxxxxx>
> > Subject: Re: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
> >
> > On Fri, Sep 11, 2020 at 12:28:47PM +0000, Ashish Kumar wrote:
> > > > Signed-off-by: kuldip dwivedi <kuldip.dwivedi@xxxxxxxxxxxxxxxx>
> >
> > > Please capture version change summary.
> > >
> > > Regards
> > > Ashish
> >
> > It's there:
> It did not mentioned about removing SWRST, which was present in v1.
> v2:Notes Looked very similar to v1.
Removed SWRST changes just to keep functionality same in ACP and DT mode,
I will post that change separately if It will be required. For tracking I
am adding this
point in notes
>
> Regards
> Ashish
> >
> > > >
> > > > Notes:
> > > >     1. Add ACPI match table, NXP members are added to confirm HID
> > > > for
> > FSPI
> > > >     2. Change the DT specific APIs to device property APIs
> > > >            so that same API can be used in DT and ACPi mode.
> > > >     3. Omit clock configuration part - in ACPI world, the firmware
> > > >            is responsible for clock maintenance.
> > > >     4. This patch is tested on LX2160A platform
5.  SWRST reset changes are removed from v1 as to keep functionality
same in ACP and DT mode, I will post that change separately if It will be
required