Re: [PATCH] gpio: Handle counting of Freescale chipselects

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Nov 27, 2019 at 11:25 AM Christophe Leroy
<christophe.leroy@xxxxxx> wrote:
> Le 27/11/2019 à 11:15, Christophe Leroy a écrit :
> > Le 27/11/2019 à 11:07, Christophe Leroy a écrit :
> >> Le 27/11/2019 à 10:40, Linus Walleij a écrit :
> >>> We have a special quirk to handle the Freescale
> >>> nonstandard SPI chipselect GPIOs in the gpiolib-of.c
> >>> file, but it currently only handles the case where
> >>> the GPIOs are actually requested (gpiod_*get()).
> >>>
> >>> We also need to handle that the SPI core attempts
> >>> to count the GPIOs before use, and that needs a
> >>> similar quirk in the OF part of the library.
> >>>
> >>> Cc: Christophe Leroy <christophe.leroy@xxxxxx>
> >>> Reported-by: Christophe Leroy <christophe.leroy@xxxxxx>
> >>> Fixes: 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors")
> >>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> >>
> >> Still getting:
> >>
> >> [    3.374867] fsl_spi: probe of ff000a80.spi failed with error -22
> >
> > Indeed,  of_spi_get_gpio_numbers() uses of_gpio_named_count(np,
> > "cs-gpios") which still returns 0;
>
> Replacing by of_gpio_named_count(np, "gpios"); , I get further down to
> the same spi_fsl_setup() warning as when renaming the property in the DTS.

Ah, I got bitten by recursion, sorry.

OK I changed to to "gpios" in my patch too, it's the right way.

Now we need to find the final culprit that makes it not even work when
renaming to "cs-gpios"...

Yours,
Linus Walleij