Re: [PATCH] gpio: Handle counting of Freescale chipselects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Le 27/11/2019 à 11:15, Christophe Leroy a écrit :


Le 27/11/2019 à 11:07, Christophe Leroy a écrit :


Le 27/11/2019 à 10:40, Linus Walleij a écrit :
We have a special quirk to handle the Freescale
nonstandard SPI chipselect GPIOs in the gpiolib-of.c
file, but it currently only handles the case where
the GPIOs are actually requested (gpiod_*get()).

We also need to handle that the SPI core attempts
to count the GPIOs before use, and that needs a
similar quirk in the OF part of the library.

Cc: Christophe Leroy <christophe.leroy@xxxxxx>
Reported-by: Christophe Leroy <christophe.leroy@xxxxxx>
Fixes: 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors")
Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Still getting:

[    3.374867] fsl_spi: probe of ff000a80.spi failed with error -22

Indeed,  of_spi_get_gpio_numbers() uses of_gpio_named_count(np, "cs-gpios") which still returns 0;

Replacing by of_gpio_named_count(np, "gpios"); , I get further down to the same spi_fsl_setup() warning as when renaming the property in the DTS.

Christophe


Christophe


Christophe


---
Mark: I will merge this through the GPIO tree if
it fixes the problem.
---
  drivers/gpio/gpiolib-of.c | 27 +++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)

diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 80ea49f570f4..33e16fa17bd8 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -23,6 +23,29 @@
  #include "gpiolib.h"
  #include "gpiolib-of.h"
+/**
+ * of_gpio_spi_cs_get_count() - special GPIO counting for SPI
+ * Some elder GPIO controllers need special quirks. Currently we handle
+ * the Freescale GPIO controller with bindings that doesn't use the
+ * established "cs-gpios" for chip selects but instead rely on
+ * "gpios" for the chip select lines. If we detect this, we redirect
+ * the counting of "cs-gpios" to count "gpios" transparent to the
+ * driver.
+ */
+int of_gpio_spi_cs_get_count(struct device *dev, const char *con_id)
+{
+    struct device_node *np = dev->of_node;
+
+    if (!IS_ENABLED(CONFIG_SPI_MASTER))
+        return 0;
+    if (strcmp(con_id, "cs"))
+        return 0;
+    if (!of_device_is_compatible(np, "fsl,spi") &&
+        !of_device_is_compatible(np, "aeroflexgaisler,spictrl"))
+        return 0;
+    return of_gpio_get_count(dev, NULL);
+}
+
  /*
   * This is used by external users of of_gpio_count() from <linux/of_gpio.h>
   *
@@ -35,6 +58,10 @@ int of_gpio_get_count(struct device *dev, const char *con_id)
      char propname[32];
      unsigned int i;
+    ret = of_gpio_spi_cs_get_count(dev, con_id);
+    if (ret > 0)
+        return ret;
+
      for (i = 0; i < ARRAY_SIZE(gpio_suffixes); i++) {
          if (con_id)
              snprintf(propname, sizeof(propname), "%s-%s",




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux