Re: [PATCH] spi: sh-msiof: Add reset of registers before starting transfer

[Simon Horman <horms@xxxxxxxxxxxx>]

On Fri, Mar 01, 2019 at 10:28:21AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Mar 1, 2019 at 10:25 AM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > On Thu, Feb 28, 2019 at 12:02:15PM +0100, Geert Uytterhoeven wrote:
> > > From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> > >
> > > In accordance with hardware specification Ver 1.0, reset register
> > > transmission / reception setting before transfer.
> > >
> > > Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >
> > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> 
> Thanks!
> 
> > > --- a/drivers/spi/spi-sh-msiof.c
> > > +++ b/drivers/spi/spi-sh-msiof.c
> > > @@ -130,6 +130,8 @@ struct sh_msiof_spi_priv {
> > >  #define CTR_TFSE     0x00004000 /* Transmit Frame Sync Signal Output Enable */
> > >  #define CTR_TXE              0x00000200 /* Transmit Enable */
> > >  #define CTR_RXE              0x00000100 /* Receive Enable */
> > > +#define CTR_TXRST    0x00000002 /* Transmit Reset */
> > > +#define CTR_RXRST    0x00000001 /* Receive Reset */
> >
> > nit: can we start using the BIT() macro here?
> 
> Sure, if you want to convert the whole driver... ;-)
> Note that many of them are multi-bit fields.

Yes, my 2c worth is to use BIT() and GENMASK() throughout the driver.