Re: [PATCH] spi: sh-msiof: Add reset of registers before starting transfer

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Simon,

On Fri, Mar 1, 2019 at 10:25 AM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Thu, Feb 28, 2019 at 12:02:15PM +0100, Geert Uytterhoeven wrote:
> > From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> >
> > In accordance with hardware specification Ver 1.0, reset register
> > transmission / reception setting before transfer.
> >
> > Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

Thanks!

> > --- a/drivers/spi/spi-sh-msiof.c
> > +++ b/drivers/spi/spi-sh-msiof.c
> > @@ -130,6 +130,8 @@ struct sh_msiof_spi_priv {
> >  #define CTR_TFSE     0x00004000 /* Transmit Frame Sync Signal Output Enable */
> >  #define CTR_TXE              0x00000200 /* Transmit Enable */
> >  #define CTR_RXE              0x00000100 /* Receive Enable */
> > +#define CTR_TXRST    0x00000002 /* Transmit Reset */
> > +#define CTR_RXRST    0x00000001 /* Receive Reset */
>
> nit: can we start using the BIT() macro here?

Sure, if you want to convert the whole driver... ;-)
Note that many of them are multi-bit fields.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds