Re: [PATCH 1/4] spi: mt7621: Move SPI driver out of staging

[Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>]

On Thu, Jan 31, 2019 at 02:25:51PM +0100, Stefan Roese wrote:
> This patch moves the MT7621 SPI driver, which is used on some Ralink /
> MediaTek MT76xx MIPS SoC's, out of the staging directory. No changes to
> the source code are done in this patch.
> 
> This driver version was tested successfully on an MT7688 based platform
> with an SPI NOR on CS0 and an SPI NAND on CS1 without any issues (so
> far).
> 
> Signed-off-by: Stefan Roese <sr@xxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: NeilBrown <neil@xxxxxxxxxx>
> Cc: Sankalp Negi <sankalpnegi2310@xxxxxxxxx>
> Cc: Chuanhong Guo <gch981213@xxxxxxxxx>
> Cc: John Crispin <john@xxxxxxxxxxx>
> ---
>  drivers/spi/Kconfig                              | 6 ++++++
>  drivers/spi/Makefile                             | 1 +
>  drivers/{staging/mt7621-spi => spi}/spi-mt7621.c | 0
>  drivers/staging/Kconfig                          | 2 --
>  drivers/staging/Makefile                         | 1 -
>  drivers/staging/mt7621-spi/Kconfig               | 6 ------
>  drivers/staging/mt7621-spi/Makefile              | 1 -
>  drivers/staging/mt7621-spi/TODO                  | 5 -----
>  8 files changed, 7 insertions(+), 15 deletions(-)
>  rename drivers/{staging/mt7621-spi => spi}/spi-mt7621.c (100%)
>  delete mode 100644 drivers/staging/mt7621-spi/Kconfig
>  delete mode 100644 drivers/staging/mt7621-spi/Makefile
>  delete mode 100644 drivers/staging/mt7621-spi/TODO

Patches 2-4 should be merged first, before you move this out of the
staging tree.

Also, it's hard for the spi people to review such a thing, as they only
see a "move".

Most of the time, people just submit a brand new patch, adding the
driver, and then when that gets accepted into the subsystem-specific
tree, I take a patch that deletes this from the staging tree.  That's
more "obvious" what is going on and keeps it easier to review.

thanks,

greg k-h