[PATCH 1/2] spi/trace: drop useless and wrong (but harmless) casts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



bus_num, chip_select and len are already ints, so there is no gain in
casting them to int. xfer is a pointer to a struct spi_transfer. Casting
that to struct spi_message * is wrong but as only the pointer value is
used for the %p format specifier no harm is done.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
 include/trace/events/spi.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/include/trace/events/spi.h b/include/trace/events/spi.h
index 277bb9d25779..6eb014f59efb 100644
--- a/include/trace/events/spi.h
+++ b/include/trace/events/spi.h
@@ -129,10 +129,9 @@ DECLARE_EVENT_CLASS(spi_transfer,
 		__entry->len = xfer->len;
 	),
 
-        TP_printk("spi%d.%d %p len=%d", (int)__entry->bus_num,
-		  (int)__entry->chip_select,
-		  (struct spi_message *)__entry->xfer,
-		  (int)__entry->len)
+        TP_printk("spi%d.%d %p len=%d",
+		  __entry->bus_num, __entry->chip_select,
+		  __entry->xfer, __entry->len)
 );
 
 DEFINE_EVENT(spi_transfer, spi_transfer_start,
-- 
2.19.1




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux