Hello, the first patch is just a cleanup. I'm not entirely sure if that cast is really harmless or if on some of the more obscure architectures that cast actually hurts. The second patch is the one I care about: It includes the buffer contents related to the transfers. Actually for spi_transfer_start it shouldn't be relevant what is the content of the rx buffer and symmetrically tx should not matter for spi_transfer_stop. To drop these from the output some restructuring would be needed (i.e. drop the common code for spi_transfer_start and spi_transfer_stop and implement them separately). Apart from increased trace buffer usage there is no harm in the suggested solution though. What is the preference here? Best regards Uwe Uwe Kleine-König (2): spi/trace: drop useless and wrong (but harmless) casts spi/trace: include buffer contents in traces include/trace/events/spi.h | 31 +++++++++++++++++++++++++++---- 1 file changed, 27 insertions(+), 4 deletions(-) -- 2.19.1