Re: [PATCH v3 0/5] spi: imx: Fix polarity switching for mx51-ecspi

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

Hello Mark,

On Tue, Dec 11, 2018 at 01:14:28AM +0000, Mark Brown wrote:
> On Mon, Dec 10, 2018 at 10:52:41PM +0100, Uwe Kleine-König wrote:
> 
> > In my eyes this series is ready to go in. The feedback I got so far was
> > only that there could be done still more. And given that patch 2 is a
> > fix I'd like to see this in 4.21.
> 
> It looked like there was an unanswered question about if patch 2 was
> needed or not?  Marek?

I cannot find an unanswered question. There is a workaround that Marek
introduced in 6fd8b8503a0dcf66510314dc054745087ae89f94 that might not be
needed any more with my patch 2. So it's the other way round: If Marek's
problem is fixed by patch 2, my patch is the better one. I have problems
with SCK changing polarity when CS is already asserted in the presence
of Marek's change. After my change they are gone. Even if this
workaround is superflous now, it doesn't hurt and IMHO the question if
it is needed or not should not delay my fix.

If I miss something, can you please point out the message-id?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |