On Tue, Nov 27, 2018 at 01:21:27AM +0100, Anatolij Gustschin wrote: > Mark Brown broonie@xxxxxxxxxx wrote: > >> + if (max_cs > 12) { > >> + dev_err(dev, "Invalid max CS in platform data: %d\n", max_cs); > >> + return -EINVAL; > >> + } > >> + dev_dbg(dev, "CS count %d, max CS %d\n", num_cs, max_cs); > >> + max_cs += 1; /* including CS0 */ > >Why not just size the array based on the platform data? > The driver must also support multiple SPI slaves with additional control > pins (besides SPI chip-select gpios). There are devices with not adjacent > chip-select gpios or devices with single chip-select gpio starting at > some offset. The array size is not always the number of chip-selects > or the max. chip-select, e.g.: A few unused entries really won't matter.
Attachment:
signature.asc
Description: PGP signature