On 11/20/2018 06:42 AM, masonccyang@xxxxxxxxxxx wrote: > Hi Marek, > > Marek Vasut <marek.vasut@xxxxxxxxx> 已在 2018/11/19 下午 09:49:31 上寫入: > >> Marek Vasut <marek.vasut@xxxxxxxxx> >> 2018/11/19 下午 09:49 >> >> To >> >> Mason Yang <masonccyang@xxxxxxxxxxx>, broonie@xxxxxxxxxx, >> tpiepho@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux- >> spi@xxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, Simon Horman >> <horms@xxxxxxxxxxxx>, >> >> cc >> >> boris.brezillon@xxxxxxxxxxx, juliensu@xxxxxxxxxxx, Geert >> Uytterhoeven <geert+renesas@xxxxxxxxx>, zhengxunli@xxxxxxxxxxx >> >> Subject >> >> Re: [PATCH 2/2] dt-binding: spi: Document Renesas R-Car RPC >> controller bindings >> >> On 11/19/2018 11:01 AM, Mason Yang wrote: >> > Document the bindings used by the Renesas R-Car D3 RPC controller. >> > >> > Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> >> > --- >> > .../devicetree/bindings/spi/spi-renesas-rpc.txt | 33 +++++++++ >> +++++++++++++ >> > 1 file changed, 33 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/spi/spi- >> renesas-rpc.txt >> > >> > diff --git a/Documentation/devicetree/bindings/spi/spi-renesas- >> rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> > new file mode 100644 >> > index 0000000..8286cc8 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> > @@ -0,0 +1,33 @@ >> > +Renesas R-Car D3 RPC controller Device Tree Bindings >> > +---------------------------------------------------- >> > + >> > +Required properties: >> > +- compatible: should be "renesas,rpc-r8a77995" >> > +- #address-cells: should be 1 >> > +- #size-cells: should be 0 >> > +- reg: should contain 2 entries, one for the registers and one >> for the direct >> > + mapping area >> > +- reg-names: should contain "rpc_regs" and "dirmap" >> > +- interrupts: interrupt line connected to the RPC SPI controller >> >> Do you also plan to support the RPC HF mode ? And if so, how would that >> look in the bindings ? I'd like to avoid having to redesign the bindings >> later to handle both the SPI and HF modes. >> > > I patched this RPC SPI/Octa driver is for mx25uw51245g and you may also > refer to Boris's patch. [1][2][3] Does this mean the driver is specific to one particular kind of flash ? > [1] https://patchwork.kernel.org/cover/10638055/ > [2] https://patchwork.kernel.org/patch/10638057/ > [3] https://patchwork.kernel.org/patch/10638085/ -- Best regards, Marek Vasut