> Lukas Wunner <lukas@xxxxxxxxx> hat am 13. November 2018 um 09:07 geschrieben: > > > On Sat, Nov 10, 2018 at 12:25:34PM +0100, Stefan Wahren wrote: > > > On 08.11.2018, at 08:06, Lukas Wunner <lukas@xxxxxxxxx> wrote: > > > > +#define BCM2835_SPI_FIFO_SIZE 64 > > > > +#define BCM2835_SPI_FIFO_SIZE_3_4 48 > > > > I only have doubts about the naming FIFO_SIZE_3_4 because it describe > > a fill level not a size. > > Hm, it's three quarters of the FIFO's size, so seems sufficiently apt? Just a thought because only from the define name i wouldn't think of three quarters first. Since i don't have a better solution, please go on.
Re: [PATCH 7/7] spi: bcm2835: Speed up FIFO access if fill level is known
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 7/7] spi: bcm2835: Speed up FIFO access if fill level is known
- From: Stefan Wahren <stefan.wahren@xxxxxxxx>
- Date: Tue, 13 Nov 2018 20:07:17 +0100 (CET)
- Cc: Mark Brown <broonie@xxxxxxxxxx>, Eric Anholt <eric@xxxxxxxxxx>, Mathias Duckeck <m.duckeck@xxxxxxxxx>, Frank Pavlic <f.pavlic@xxxxxxxxx>, Noralf Tronnes <noralf@xxxxxxxxxxx>, kernel@xxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx
- Importance: Medium
- In-reply-to: <20181113080740.lrhfo656m7e4kb7a@wunner.de>
- References: <807EBC97-54BD-49D5-86C8-3768FB4C0105@martin.sperl.org> <52205641.172367.1541849134970@email.ionos.de> <20181113080740.lrhfo656m7e4kb7a@wunner.de>
- Follow-Ups:
- Re: [PATCH 7/7] spi: bcm2835: Speed up FIFO access if fill level is known
- From: Florian Fainelli
- Re: [PATCH 7/7] spi: bcm2835: Speed up FIFO access if fill level is known
- References:
- Prev by Date: Re: [PATCH v2 2/3] spi: add FTDI MPSSE SPI controller driver
- Next by Date: Re: [RFC PATCH] spi: add driver for the SiFive SPI controller
- Previous by thread: Re: [PATCH 7/7] spi: bcm2835: Speed up FIFO access if fill level is known
- Next by thread: Re: [PATCH 7/7] spi: bcm2835: Speed up FIFO access if fill level is known
- Index(es):
 |